On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote: > Could you please accept the following patch?
Probably, but I'd like to have a reply to my comments below first. > diff -ruNp a/include/asm-m32r/serial.h b/include/asm-m32r/serial.h > --- a/include/asm-m32r/serial.h 2004-12-25 06:35:40.000000000 +0900 > +++ b/include/asm-m32r/serial.h 2005-03-24 17:25:05.812651363 +0900 Can m32r accept PCMCIA cards? If so, this may mean that 8250.c gets built, which will use this file to determine where it should look for built-in 8250 ports. If this file is used to describe non-8250 compatible ports, you could end up with a nasty mess. Therefore, I recommend that you do not use asm-m32r/serial.h to describe your SIO ports. Instead, since these definitions are private to your own driver, you may consider moving them into the driver, or a header file closely associated with your driver in drivers/serial. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
