Commit-ID: da4c54457e6d8262423aded4bcbccc4103049506
Gitweb: http://git.kernel.org/tip/da4c54457e6d8262423aded4bcbccc4103049506
Author: Peter Zijlstra <pet...@infradead.org>
AuthorDate: Tue, 2 Sep 2014 22:21:26 +0200
Committer: Ingo Molnar <mi...@kernel.org>
CommitDate: Wed, 10 Sep 2014 11:45:06 +0200
locking, mips: Fix atomics
The patch folding the atomic ops had two silly fails in the _return
primitives.
Fixes: ef31563e950c ("locking,arch,mips: Fold atomic_ops")
Reported-by: Guenter Roeck <li...@roeck-us.net>
Tested-by: Guenter Roeck <li...@roeck-us.net>
Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Cc: Bart Van Assche <bvanass...@acm.org>
Cc: Hannes Reinecke <h...@suse.de>
Cc: Linus Torvalds <torva...@linux-foundation.org>
Cc: Maciej W. Rozycki <ma...@codesourcery.com>
Cc: Markos Chandras <markos.chand...@imgtec.com>
Cc: Paul Burton <paul.bur...@imgtec.com>
Cc: Paul E. McKenney <paul...@linux.vnet.ibm.com>
Cc: Ralf Baechle <r...@linux-mips.org>
Cc: Stephen Rothwell <s...@canb.auug.org.au>
Link: http://lkml.kernel.org/r/20140902202126.ga3...@worktop.ger.corp.intel.com
Signed-off-by: Ingo Molnar <mi...@kernel.org>
---
arch/mips/include/asm/atomic.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h
index 476fe3b..f3ee721 100644
--- a/arch/mips/include/asm/atomic.h
+++ b/arch/mips/include/asm/atomic.h
@@ -93,7 +93,7 @@ static __inline__ int atomic_##op##_return(int i, atomic_t *
v) \
" " #asm_op " %0, %1, %3 \n"
\
" sc %0, %2 \n"
\
" beqzl %0, 1b \n"
\
- " addu %0, %1, %3 \n"
\
+ " " #asm_op " %0, %1, %3 \n"
\
" .set mips0 \n"
\
: "=&r" (result), "=&r" (temp), "+m" (v->counter)
\
: "Ir" (i));
\
@@ -111,7 +111,7 @@ static __inline__ int atomic_##op##_return(int i, atomic_t
* v) \
: "Ir" (i));
\
} while (unlikely(!result));
\
\
- result = temp + i;
\
+ result = temp; result c_op i;
\
} else {
\
unsigned long flags;
\
\
@@ -387,7 +387,7 @@ static __inline__ long atomic64_##op##_return(long i,
atomic64_t * v) \
: "memory");
\
} while (unlikely(!result));
\
\
- result = temp + i;
\
+ result = temp; result c_op i;
\
} else {
\
unsigned long flags;
\
\
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
