Satoru,
Thanks for the review.
Steven,
When you have time, let me know if there are any issues with this being
applied.
--chris j arges
On 08/30/2014 08:06 AM, Satoru Takeuchi wrote:
> Hi Chris,
>
> Sorry for late reply.
>
> 2014-08-28 3:26 GMT+09:00 Chris J Arges <chris.j.ar...@canonical.com>:
>
>> When doing a manual bisect, a build can fail or a test can be inconclusive.
>> In these cases it would be helpful to be able to skip the test entirely.
>>
>> Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com>
>
> It look good to me.
>
> Reviewed-by: Satoru Takeuchi <satoru.takeu...@gmail.com>
>
> Thanks,
> Satoru
>
>>
>> ---
>> tools/testing/ktest/ktest.pl | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
>> index 55ab700..72010f4 100755
>> --- a/tools/testing/ktest/ktest.pl
>> +++ b/tools/testing/ktest/ktest.pl
>> @@ -2336,15 +2336,17 @@ sub success {
>>
>> sub answer_bisect {
>> for (;;) {
>> - doprint "Pass or fail? [p/f]";
>> + doprint "Pass, fail, or skip? [p/f/s]";
>> my $ans = <STDIN>;
>> chomp $ans;
>> if ($ans eq "p" || $ans eq "P") {
>> return 1;
>> } elsif ($ans eq "f" || $ans eq "F") {
>> return 0;
>> + } elsif ($ans eq "s" || $ans eq "S") {
>> + return -1;
>> } else {
>> - print "Please answer 'P' or 'F'\n";
>> + print "Please answer 'p', 'f', or 's'\n";
>> }
>> }
>> }
>> --
>> 1.9.1
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
