On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:
> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and
> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than
> PLAT_SAMSUNG.
Please always describe why you are doing a change. This patch
seems really pointless.
> config SERIAL_SAMSUNG_UARTS_4
> bool
> - depends on PLAT_SAMSUNG
> + depends on SERIAL_SAMSUNG
> default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 ||
> CPU_S3C2442)
> help
> Internal node for the common case of 4 Samsung compatible UARTs
>
> config SERIAL_SAMSUNG_UARTS
> int
> - depends on PLAT_SAMSUNG
> + depends on SERIAL_SAMSUNG
> default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
> default 3
> help
>
Have you checked that it still builds on all samsung platforms when
SERIAL_SAMSUNG is disabled? We have had build errors in this area
in the past.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
