On 08/29/14 16:41, Courtney Cavin wrote: > On Sat, Aug 30, 2014 at 01:14:23AM +0200, Bjorn Andersson wrote: >> From: Kumar Gala <ga...@codeaurora.org> >> >> Add driver for Qualcomm MSM Hardware Mutex block that exists on >> newer Qualcomm SoCs. >> >> Cc: Jeffrey Hugo <jh...@codeaurora.org> >> Cc: Eric Holmberg <eholm...@codeaurora.org> >> Cc: Courtney Cavin <courtney.ca...@sonymobile.com> >> Signed-off-by: Kumar Gala <ga...@codeaurora.org> >> [bjorn: added pm_runtime calls, from Courtney, >> added sfpb-mutex compatible, >> updated DT binding documentation formatting] >> Signed-off-by: Bjorn Andersson <bjorn.anders...@sonymobile.com> >> --- > [...] >> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig >> index 3612cb5..2cd39e2 100644 >> --- a/drivers/hwspinlock/Kconfig >> +++ b/drivers/hwspinlock/Kconfig >> @@ -8,6 +8,17 @@ config HWSPINLOCK >> >> menu "Hardware Spinlock drivers" >> >> +config HWSPINLOCK_MSM >> + tristate "MSM Hardware Spinlock device" >> + depends on ARCH_QCOM > This should also depend on OF, as it won't compile or work without it.
Doesn't ARCH_QCOM imply OF? ARCH_MULTIPLATFORM has a select USE_OF. > >> + select HWSPINLOCK >> + help >> + Say y here to support the MSM Hardware Mutex functionality, which >> + provides a synchronisation mechanism for the various processors on >> + the SoC. >> + >> + If unsure, say N. >> + >> Maybe MSM should be changed to qcom? Just a thought. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
