On Fri, 22 Aug 2014, Mark Brown wrote:
> On Fri, Aug 22, 2014 at 04:11:33PM -0500, at...@opensource.altera.com wrote:
>
> > + if (pdata && pdata->reg_init_data) {
> > + config.init_data = pdata->reg_init_data;
> > + } else {
> > + config.init_data = of_get_regulator_init_data(dev, np);
> > + if (!config.init_data)
> > + return -ENOMEM;
> > + }
>
> It should be fine to start with no init data - just let the regulator
> core worry about it. This will allow users to read back the state even
> if they can't change anything which is useful for system bringup or
> general debugging.
>
of_get_regulator_init_data() will only have an error if it cannot alloc
the regulator_init_data struct. That's why I did -ENOMEM. If there
is no platform data and nothing about the regulator in the device tree, we
should end up with a zeroed out regulator_init_data.
Thanks for the review.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
