On Wed, 13 Aug 2014, Andreas Werner wrote:
> The MEN 14F021P00 Board Management Controller provides an
> I2C interface to the host to access the feature implemented in the BMC.
> The BMC is a PIC Microntroller assembled on CPCI Card from MEN Mikroelektronik
> and on a few Box/Display Computer.
> 
> Added MFD Core driver, supporting the I2C communication to the device.
> 
> The MFD driver currently supports the following features:
>       - Watchdog
>       - LEDs
>       - Hwmon (voltage monitoring)
> 
> Signed-off-by: Andreas Werner <andreas.wer...@men.de>
> ---
>  drivers/mfd/Kconfig     |  12 +++++
>  drivers/mfd/Makefile    |   1 +
>  drivers/mfd/menf21bmc.c | 132 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 145 insertions(+)
>  create mode 100644 drivers/mfd/menf21bmc.c
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index b8d9ca0..bf155b9 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -453,6 +453,18 @@ config MFD_MAX8998
>         additional drivers must be enabled in order to use the functionality
>         of the device.
>  
> +config MFD_MENF21BMC
> +     tristate "MEN 14F021P00 Board Management Controller Support"
> +     depends on I2C=y

Why must I2C be built-in?

> +     select MFD_CORE
> +     help
> +       Say yes here to add support for the MEN 14F021P00 BMC
> +       which is a Board Management Controller connected to the I2C bus.
> +       The device supports multiple sub-devices like LED, HWMON  and WDT.
> +       This driver provides common support for accessing the devices;
> +       additional drivers must be enabled in order to use the
> +       functionality of the BMC device.
> +

Apart from that the patch looks good to me.

I'm assuming this can go in via the MFD tree by itself?

Acked-by: Lee Jones <lee.jo...@linaro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to