On 16 August 2014 08:35, Pavel Machek <pa...@ucw.cz> wrote: >> >> @@ -13,6 +14,7 @@ Each parameters have defined units: >> * latency: usec >> * timeout: usec >> * throughput: kbs (kilo bit / sec) >> + * memory bandwidth: kbs (kilo bit / sec) > > Would mega bits per second make sense here? > > I suppose some many-core systems would have memory bandwith > in > 10 terabit/sec, overflowing u32.
Yeah, I was a bit concerned about excessive rounding increasing the chances of going to a higher frequency step than strictly necessary, but after thinking a bit more about it, I think it won't be a problem because it would be a bad idea anyway to only take into account explicit bandwidth requirements when calculating the optimal memory bus frequency. So I agree that a coarser unit such as mbps should be more appropriate here. > Plus, if driver in 3/3 is just an example, perhaps comment > should explain that clearly? Will do. > Otherwise looks good, > > Acked-by: Pavel Machek <pa...@ucw.cz> Thanks, Tomeu > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
