On Sat, Aug 09, 2014 at 09:58:42PM +0800, Shawn Guo wrote:
> On Fri, Aug 08, 2014 at 03:02:49PM +0800, Shengjiu Wang wrote:
> > @@ -176,8 +182,12 @@ static void __init imx6q_clocks_init(struct
> > device_node *ccm_node)
> > * the "output_enable" bit as a gate, even though it's really just
> > * enabling clock output.
> > */
> > - clk[IMX6QDL_CLK_LVDS1_GATE] = imx_clk_gate("lvds1_gate", "lvds1_sel",
> > base + 0x160, 10);
> > - clk[IMX6QDL_CLK_LVDS2_GATE] = imx_clk_gate("lvds2_gate", "lvds2_sel",
> > base + 0x160, 11);
> > + clk[IMX6QDL_CLK_LVDS1_GATE] = imx_clk_gate2("lvds1_gate", "lvds1_sel",
> > base + 0x160, 10);
> > + clk[IMX6QDL_CLK_LVDS2_GATE] = imx_clk_gate2("lvds2_gate", "lvds2_sel",
> > base + 0x160, 11);
>
> I do not think you can simply change to use imx_clk_gate2() here. It's
> designed for those CCGR gate clocks, each of which is controlled by two
> bits.
>
> Shawn
>
As Lucas Stach's suggestion, we need to do add some method for mutually
exclusive clock,
lvds1_gate with lvds1_in, lvds2_gate with lvds2_in. I add
imx_clk_gate2_exclusive() function in clk-gate2.c.
So I change imx_clk_gate() to imx_clk_gate2() here.
As you said, this is not good solution. So I need your suggestion, how can I do?
First, is it allowable that to add imx_clk_gate2_exclusive() function, is there
a more better way?
second, or should I change the clk-gate.c to add exclusive control?
Thanks
wang shengjiu
> > + clk[IMX6QDL_CLK_LVDS1_IN] = imx_clk_gate2("lvds1_in", "anaclk1", base +
> > 0x160, 12);
> > + clk[IMX6QDL_CLK_LVDS2_IN] = imx_clk_gate2("lvds2_in", "anaclk2", base +
> > 0x160, 13);
> > + imx_clk_gate2_exclusive(clk[IMX6QDL_CLK_LVDS1_GATE],
> > clk[IMX6QDL_CLK_LVDS1_IN]);
> > + imx_clk_gate2_exclusive(clk[IMX6QDL_CLK_LVDS2_GATE],
> > clk[IMX6QDL_CLK_LVDS2_IN]);
> >
> > /* name
> > parent_name reg idx */
> > clk[IMX6QDL_CLK_PLL2_PFD0_352M] = imx_clk_pfd("pll2_pfd0_352m",
> > "pll2_bus", base + 0x100, 0);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
