On Fri, Aug 08, 2014 at 02:04:28PM -0300, Ezequiel Garcia wrote: > Picking on this old thread... > > On 27 May 07:12 AM, Alexander Shiyan wrote: > > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c > > > b/drivers/mtd/nand/pxa3xx_nand.c > > > index 7588fe2..7f62e7c 100644 > > > --- a/drivers/mtd/nand/pxa3xx_nand.c > > > +++ b/drivers/mtd/nand/pxa3xx_nand.c > > > @@ -1584,8 +1584,7 @@ static int alloc_nand_resource(struct > > > platform_device *pdev) > > > host->mtd = mtd; > > > host->cs = cs; > > > host->info_data = info; > > > - mtd->priv = host; > > > - mtd->owner = THIS_MODULE; > > > + mtd_setup_common_members(mtd, host, pdev); > > > > > > chip->ecc.read_page = pxa3xx_nand_read_page_hwecc; > > > chip->ecc.write_page = pxa3xx_nand_write_page_hwecc; > > > -- > > > > Should we add "driver.owner = THIS_MODULE" field for struct platform_driver > > in this case? > > > > As far as I can see, for platform drivers, the owner of the driver is fixed to > THIS_MODULE in __platform_driver_register().
Looks like it. So any driver using module_platform_driver() or platform_driver_register() and also initializes platform_driver.driver.owner is just being redundant. Maybe another "cleanup" project for Jingoo Han? ;) > If there's anything left to fix for this driver, please let me know. pxa3xx_nand is still missing a parent for its MTD's (mtd->dev.parent). I have a follow-up patch queued up locally that I need to send out sometime. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
