On Tue, 5 Aug 2014, Bartlomiej Zolnierkiewicz wrote:
> Commit af040ffc9ba1 ("ARM: make it easier to check the CPU part
> number correctly") has left (now unused in the upstream tree and
> marked as deprecated) read_cpuid_part_number() while changing
> the way it works (using the old function with the definitions will
> now always evaluate as false). This causes problems with porting
> older code to new kernels as the code compiles (with warnings but
> they are very easy to miss) but it can fail silently or work just
> fine depending on the used hardware.
>
> Remove unused/deprecated read_cpuid_part_number() so developers
> have to update their code during build time instead of running into
> tricky runtime problems later.
>
> Please see the commit af040ffc9ba1 for details on how to convert
> your old out-of-tree code to use read_cpuid_part() instead of
> read_cpuid_part_number().
>
> Cc: Nicolas Pitre <n...@linaro.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>
If there are no more in-tree users then it should go indeed.
Acked-by: Nicolas Pitre <n...@linaro.org>
> ---
> arch/arm/include/asm/cputype.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: b/arch/arm/include/asm/cputype.h
> ===================================================================
> --- a/arch/arm/include/asm/cputype.h 2014-08-04 15:09:30.166988335 +0200
> +++ b/arch/arm/include/asm/cputype.h 2014-08-05 15:40:03.793317783 +0200
> @@ -182,11 +182,6 @@ static inline unsigned int __attribute_c
> return read_cpuid_id() & 0xff00fff0;
> }
>
> -static inline unsigned int __attribute_const__ __deprecated
> read_cpuid_part_number(void)
> -{
> - return read_cpuid_id() & 0xFFF0;
> -}
> -
> static inline unsigned int __attribute_const__ xscale_cpu_arch_version(void)
> {
> return read_cpuid_id() & ARM_CPU_XSCALE_ARCH_MASK;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
