Em Wed, Jul 23, 2014 at 03:05:25PM +0200, Jiri Olsa escreveu: > On Tue, Jul 22, 2014 at 04:18:01PM +0300, Adrian Hunter wrote: > > 'perf record' post-processes the event stream to create > > a list of build-ids for object files for which sample > > events have been recorded. That results in those object > > files being recorded in the build-id cache. > > > > In the case of VDSO, perf tools reads it from memory > > and copies it into a temporary file, which as decribed > > above, gets added to the build-id cache. > > > > Then when the perf.data file is processed by other > > tools, the build-id of VDSO is listed in the perf.data > > file and the VDSO can be read from the build-id cache. > > In that case the name of the map, the short name of the > > DSO, and the entry in the build-id cache are all > > "[vdso]". > > > > heya, > I reviewed vdso changes: > > perf tools: Pass machine to vdso__dso_findnew() > perf tools: Group VDSO global variables into a structure > perf tools: Fix the lifetime of the VDSO temporary file > perf tools: Add vdso__new() > perf tools: Separate the VDSO map name from the VDSO dso name > perf tools: Build programs to copy 32-bit compatibility VDSOs > perf tools: Add dso__type() > perf tools: Add thread parameter to vdso__dso_findnew() > perf tools: Add support for 32-bit compatibility VDSOs > > apart from small comments for above patches: > > Acked-by: Jiri Olsa <jo...@redhat.com> > > Arnaldo, > I can handle those if needed, please let me know
I can take those after I go thru them, will add your acked-by. But since you sayd "I reviewed", wouldn't it be better to s/Acked-by/Reviewed-by/g ? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
