> On 16 July 2014 at 19:20 Zach Brown <[email protected]> wrote: > > > On Tue, Jul 15, 2014 at 09:17:17PM +0200, Fabian Frederick wrote: > > Fix the following sparse warning: > > fs/btrfs/send.c:518:51: warning: incorrect type in argument 2 (different > > address spaces) > > fs/btrfs/send.c:518:51: expected char const [noderef] * > > fs/btrfs/send.c:518:51: got char * > > > > We can safely use (const char __user *) with set_fs(KERNEL_DS) > > Yeah, that cast is correct. > > Reviewed-by: Zach Brown <[email protected]> > > > @@ -515,7 +515,8 @@ static int write_buf(struct file *filp, const void *buf, > > u32 len, loff_t *off) > > Though this probably wants to be rewritten in terms of kernel_write(). > That'd give an opportunity to get rid of the sctx->send_off and have it > use f_pos in the filp.
Do you mean directly call kernel_write from send_cmd/send_header ? I guess that loop around vfs_write in write_buf is there for something ... Fabian > > - z -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
