From: Michel Dänzer <mic...@daenzer.net> Date: Thu, 17 Jul 2014 09:55:59 +0900
> On 17.07.2014 07:25, David Miller wrote: >> From: Francois Romieu <rom...@fr.zoreil.com> >> Date: Tue, 15 Jul 2014 23:54:12 +0200 >> >>> Hayes Wang <hayesw...@realtek.com> : >>>> Michel D?nzer [mailto:mic...@daenzer.net] >>> [...] >>>>> Without this, the ethernet port on my ASUS A88X Pro mainboard stops >>>>> working sometimes, with messages like these in dmesg: >>>>> >>>>> AMD-Vi: Event logged [IO_PAGE_FAULT device=05:00.0 >>>>> domain=0x001e address=0x0000000000003000 flags=0x0050] >>>> >>>> I search the information about your issue. It seems to be >>>> relative to the IOMMU. I don't sure if your patch is the root >>>> cause or a workaround. >>> >>> Btw, a few extra identifiers in rtl_init_rxcfg may improve consistency: >>> >>> missing | included >>> -------------------------------+------------------------------- >>> RTL_GIGA_MAC_VER_36 (8168f) | RTL_GIGA_MAC_VER_35 (8168f) >>> RTL_GIGA_MAC_VER_38 (RTL8411) | RTL_GIGA_MAC_VER_44 (RTL8411) >>> RTL_GIGA_MAC_VER_39 (RTL8106e) | RTL_GIGA_MAC_VER_43 (RTL8106e) >>> RTL_GIGA_MAC_VER_37 (RTL8402) | >> >> Michel please take Francois's feedback here into consideration and also >> provide a more detailed commit message so other people reading the commit >> can understand your reasoning for making this change, not just what the >> result might be for making it. > > I'm afraid I can't do that. I don't really understand any of this stuff, > I just googled the IOMMU event message, found similar patches for other > chipsets, and adapted them for my mainboard until the problem stopped. And if so, that's exactly what I want you to say in the commit message. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/