From: Will Deacon
...
> > + BUG_ON(imm < 0 || imm > 65535);
>
> Do this check with masking instead?
The compiler will convert that to a single unsigned comparison.
...
> > + BUG_ON(shift != 0 && shift != 16 && shift != 32 &&
> > + shift != 48);
OTOH I don't think it will convert that to:
BUG_ON(shift & ~48);
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
