Em Mon, Jul 14, 2014 at 01:03:02PM +0300, Adrian Hunter escreveu: > Add a function to deliver synthesized events from > within a session.
Why not put this in perf_session_deliver_event (and fix its naming, renaming it to perf_session__deliver_event)? The way you did makes me wonder why you want to fallback to perf_session_deliver_event, i.e. would a normal event come thru a function which name implies it should be used only for synth events? Also that events_stats__inc() looks suspicious there :-\ - Arnaldo > Signed-off-by: Adrian Hunter <[email protected]> > --- > tools/perf/util/session.c | 14 ++++++++++++++ > tools/perf/util/session.h | 5 +++++ > 2 files changed, 19 insertions(+) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 708e1c1..433884c 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1066,6 +1066,20 @@ static s64 perf_session__process_user_event(struct > perf_session *session, > } > } > > +int perf_session__deliver_synth_event(struct perf_session *session, > + union perf_event *event, > + struct perf_sample *sample, > + struct perf_tool *tool) > +{ > + events_stats__inc(&session->stats, event->header.type); > + > + if (event->header.type >= PERF_RECORD_USER_TYPE_START) > + return perf_session__process_user_event(session, event, tool, > + 0); > + > + return perf_session_deliver_event(session, event, sample, tool, 0); > +} > + > static void event_swap(union perf_event *event, bool sample_id_all) > { > perf_event__swap_op swap; > diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h > index 39327ca..86f1bb4 100644 > --- a/tools/perf/util/session.h > +++ b/tools/perf/util/session.h > @@ -130,6 +130,11 @@ extern volatile int session_done; > > #define session_done() (*(volatile int *)(&session_done)) > > +int perf_session__deliver_synth_event(struct perf_session *session, > + union perf_event *event, > + struct perf_sample *sample, > + struct perf_tool *tool); > + > int perf_event__process_id_index(struct perf_tool *tool, > union perf_event *event, > struct perf_session *session); > -- > 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
