On Tue, Jul 08, 2014 at 11:42:42AM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > On Tuesday 08 July 2014 07:14 AM, Greg KH wrote: > > On Mon, Jul 07, 2014 at 12:18:20PM +0530, Kishon Vijay Abraham I wrote: > >> From: Kamil Debski <k.deb...@samsung.com> > >> > >> The Exynos4412 USB 2.0 PHY hardware differs from the description provided > >> in the documentation. Some register bits have different function. This > >> patch fixes the defines of register bits and changes the way how phys are > >> powered on and off. > >> > >> Signed-off-by: Kamil Debski <k.deb...@samsung.com> > >> Tested-by: Marek Szyprowski <m.szyprow...@samsung.com> > >> Tested-by: Daniel Drake <dr...@endlessm.com> > >> Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com> > >> --- > >> drivers/phy/phy-exynos4x12-usb2.c | 112 > >> +++++++++++++++++++++++++------------ > >> drivers/phy/phy-exynos5250-usb2.c | 2 - > >> drivers/phy/phy-samsung-usb2.h | 3 +- > >> 3 files changed, 77 insertions(+), 40 deletions(-) > >> > > > > This doesn't look like a regression fix for 3.16-final, it looks like a > > "new feature" to me :( > > This patch was primarily due to the incorrectly documented register bits in > the > manual. So thought this would qualify as fix and should be in 3.16.
Sorry, that's really big for a patch so late in the -rc cycle. There should only be real regressions or reported bugfixes now. Care to redo this whole series based on these responses? I can't take it as-is. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
