On Mon, 30 Jun 2014 19:50:25 +0200 Oleg Nesterov <o...@redhat.com> wrote:
> Well, I do not really mind. But to me it looks more consistent this way, > if-something-fail-goto-err_label. > > IOW, I think that the code should either not use err-labels, or always > use them like above. Ah I missed the other error labels. Yeah, we should keep the patch as is to be consistent (also it means I don't need to restart a test that's already been running for hours). -- Steve > > Besides, perhaps we will add "if (file) uprobe_apply()" after _register() > to mix perf/ftrace, then we will need to change this "if (!ret)" code again. > > Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
