Sometimes the comm field in the trace.dat file can be empty which means that the
event parsing stuff can pass a NULL into pevent_register_comm.  To fix this just
check if we are NULL and generate a bogus comm name for that PID.  This keeps us
from segfaulting.  Thanks,

Signed-off-by: Josef Bacik <jba...@fb.com>
---
 event-parse.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/event-parse.c b/event-parse.c
index 18b3587..00304fe 100644
--- a/event-parse.c
+++ b/event-parse.c
@@ -303,7 +303,10 @@ int pevent_register_comm(struct pevent *pevent, const char 
*comm, int pid)
        if (!item)
                return -1;
 
-       item->comm = strdup(comm);
+       if (comm)
+               item->comm = strdup(comm);
+       else
+               item->comm = strdup("<...>");
        if (!item->comm) {
                free(item);
                return -1;
-- 
2.0.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to