On Tue, 24 Jun 2014 02:20:50 +0200 "Luis R. Rodriguez" <[email protected]> wrote:
> On Mon, Jun 23, 2014 at 03:41:34PM -0700, Andrew Morton wrote: > > On Wed, 18 Jun 2014 13:45:37 -0700 "Luis R. Rodriguez" > > <[email protected]> wrote: > > > > > ... > > > > > > If an increase is required the ring buffer is increased to > > > + the next power of 2 that can fit both the minimum kernel ring buffer > > > + (LOG_BUF_SHIFT) plus the additional worst case CPU contributions. > > > > > > ... > > > > > > + log_buf_len_update(cpu_extra + __LOG_BUF_LEN); > > > +} > > > > I'd have expected > > > > total_cpu_space = minimum-per-cpu-len * nr_possible_cpus; > > log_buf_len = max(__LOG_BUF_LEN, total_cpu_space) > > > > but here you added __LOG_BUF_LEN to total_cpu_space and I cannot work > > out why. > > . > > Ah, because its cpu_extra, not total_cpu_space that is being > computed, the goal was to see how much extra junk on the > worst case a CPU might contribute. The __LOG_BUF_LEN is the > default size, so we combine both. Well... why? Isn't it simpler and more direct to say "I want at least 32k per CPU"? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
