On Monday 07 March 2005 14:24, Benoit Boissinot wrote: > alps_get_model returns a pointer or NULL in case of errors, so we need to > check for the results being NULL, not negative.
2.6.11-bk2: int alps_get_model(struct psmouse *psmouse) takes 1 argument, returns -1 on error 2.6.11-mm1: static struct alps_model_info *alps_get_model(struct psmouse *psmouse, int *version) takes 2 arguments, returns NULL on error > --- linux-clean/drivers/input/mouse/alps.c > +++ linux-vanilla/drivers/input/mouse/alps.c > - if ((model = alps_get_model(psmouse)) < 0) > + if (!(model = alps_get_model(psmouse))) > - if ((model = alps_get_model(psmouse)) < 0) > + if (!(model = alps_get_model(psmouse))) > - if (alps_get_model(psmouse) < 0) > + if (!alps_get_model(psmouse)) To what version of kernel this patch should be applied? Alexey - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/