On Saturday 05 March 2005 20:58, Dave Hansen wrote:
> On Sat, 2005-03-05 at 15:35 +0200, Alexey Dobriyan wrote:
> > > + }
> > > + printk(KERN_DEBUG "\n");
> > ^^^^^^^^^^
> > > +}
> >
> > Too much KERN_DEBUG.
>
> On my system, that ends up printing out 4 or 5 lines of output per node,
> but it's quite invaluable if you're debugging early memory setup issues.
> It is KERN_DEBUG after all. What does it do on your system?
>
> I'm not horribly opposed to removing some of this output, let's just
> make sure...
You misundestood. I'm not proposing to remove these printk's altogether. I'm
for removing KERN_DEBUG solely in the middle of the line.
Try the following program with and without 3-rd and 4-th KERN_DEBUG.
Alexey
============================================================================
#include <stdio.h>
#define KERN_DEBUG "<7>"
int main(void)
{
int i;
printf(KERN_DEBUG " Setting physnode_map array to node:\n");
printf(KERN_DEBUG " ");
for (i = 0; i < 10; i++)
printf(KERN_DEBUG "%d ", i);
printf(KERN_DEBUG "\n");
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
