On Mon, 16 Jun 2014 09:17:12 -0400 Peter Hurley <[email protected]> wrote:
> ASYNC_CLOSING is no longer used in the tty core; use private flag > info->closing as substitute. > > CC: Karsten Keil <[email protected]> > CC: [email protected] > Signed-off-by: Peter Hurley <[email protected]> > --- > drivers/isdn/i4l/isdn_tty.c | 14 +++++++------- > include/linux/isdn.h | 1 + > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c > index 732f68a..5310932 100644 > --- a/drivers/isdn/i4l/isdn_tty.c > +++ b/drivers/isdn/i4l/isdn_tty.c > @@ -1577,8 +1577,7 @@ isdn_tty_close(struct tty_struct *tty, struct file > *filp) > #endif > return; > } > - port->flags |= ASYNC_CLOSING; > - > + info->closing = 1; This is not sane C because > + int closing:1; /* port count has dropped to 0 > */ has the values 0 and -1. Using a bool would let the compiler figure out what it wanted to do and do the right thing. It'll probably generate identical code for most processors but it gives it the freedom to do better. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
