> + unsigned long cur_index; > I wonder why move this particular declaration here? > The only user is still in that one conditional branch anyway. These changes are for fixing warning of line over 80 chars and indent. maybe I should change 'unsigned long' to 'u64' keeping the line of code in the same place. >> /* >> * Consistency guarantees: following possibilities exist for the >> @@ -864,11 +865,13 @@ int ccc_prep_size(const struct lu_env *env, struct >> cl_object *obj, >> * linux-2.6.18-128.1.1 miss to do that. >> * --bug 17336 */ >> loff_t size = cl_isize_read(inode); >> - unsigned long cur_index = start >> >> PAGE_CACHE_SHIFT; >> + >> + cur_index = start >> PAGE_CACHE_SHIFT; >> + loff_t check = ((size - 1) >> PAGE_CACHE_SHIFT); > This used to produce a warning about mixing code and declarations in the > past. > Probably a bad idea to mix them anyway. Will create a separate patch for mixed declaration error which is still present.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
