Hi. On Sat, 2005-03-05 at 10:26, Rafael J. Wysocki wrote: > Yes. I thought about using PG_nosave in the begining, but there's a > > BUG_ON(PageReserved(page) && PageNosave(page)); > > in swsusp.c:saveable() that I just didn't want to trigger. It seems to me, > though, that we don't need it any more, do we? > > > He also found a few places where reserved page becomes un-reserved, > > and you probably need to fix those, too. > > Yes, I think I'll just port the Nigel's patch to x86-64. BTW, it's striking > that we found similar solutions independently (I didn't know the Nigel's > patch before :-)).
I should clarify credit. I didn't work on that code. I don't recall now whether it was Michael Frank or Bernard Blackham that came up with this version. (This was about a year ago IIRC). > Unfortunately, it turns out that the patch does not fix my problem with random > reboots during resume on battery power, but I really think that we need to > mark > non-RAM areas with PG_nosave, at least for sanity reasons (eg to be sure that > we do not break things by dumping stuff to where we should not write to). Yes. I believed that that's what this patch does. Since I didn't write it myself, I'm a little fuzzy on that issue. I'll bring Bernard in, perhaps he can clarify?.. Nigel -- Nigel Cunningham Software Engineer, Canberra, Australia http://www.cyclades.com Bus: +61 (2) 6291 9554; Hme: +61 (2) 6292 8028; Mob: +61 (417) 100 574 Maintainer of Suspend2 Kernel Patches http://softwaresuspend.berlios.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
