On 06/03, Steven Rostedt wrote: > > On Tue, 3 Jun 2014 21:25:25 +0200 > Oleg Nesterov <o...@redhat.com> wrote: > > > On 06/03, Steven Rostedt wrote: > > > > > > You know, this code could use some comments. I may send you a patch, > > > because that __lock_task_sighand() is doing a lot of subtle things and > > > there's not a single comment explaining it :-( > > > > Yes, agreed. Not only SLAB_DESTROY_BY_RCU is not obvious, local_irq_save() > > is not clear at all. The latter already has a doc patch from Paul, I'll try > > to add more comments on top once I see that patch in Linus's tree. > > > > But I would be happy if you send the patch ;) > > > > And this reminds me... I still think that __lock_task_sighand() should be > > de-uglified. I already sent the patch, probably I'll resend it. > > I'd be happy to document the hell out of that function, but it sounds > like you have some updates to it.
Paul has, I don't know where ;) That patch adds the comments to explain the mysterious local_irq_disable() at the start. On top of another patch which documents the subtle problems with preemption and rcu_read_unlock(). As for the cleanup I have, it is nowhere and I'll resend it later. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
