minor (Rafael usually fixes it up, but still): $subject: PM / OPP: On 05/27/2014 06:50 AM, Viresh Kumar wrote: > When none of CONFIG_PM_OPP or CONFIG_OF is enabled we use the dummy > implementation of of_init_opp_table() routine, which returns -EINVAL > currently. > -EINVAL can confuse the callers a bit as it can have other meanings for the > actual implementation of this routine. > > It is more appropriate to return -ENOSYS instead to avoid confusion at caller. > > Suggested-and-reviewed-by: Sudeep Holla <[email protected]> > Signed-off-by: Viresh Kumar <[email protected]>
otherwise, Acked-by: Nishanth Menon <[email protected]> > --- > include/linux/pm_opp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 0330217..6668150 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -112,7 +112,7 @@ int of_init_opp_table(struct device *dev); > #else > static inline int of_init_opp_table(struct device *dev) > { > - return -EINVAL; > + return -ENOSYS; > } > #endif > > -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
