On 05/27/14 at 09:34am, Vivek Goyal wrote:
> On Mon, May 26, 2014 at 04:39:35PM +0800, Dave Young wrote:
> >
> > For efi=old_map and any old_map quirks like SGI UV in current
> > tree kexec/kdump will fail because it depends on the new 1:1 mapping.
> >
> > Thus export the mapping method to sysfs so kexec tools can switch
> > to original way to boot.
> >
> > Since we have efi.flags for all efi facilities so let's just export the
> > efi.flags itself, it maybe useful for other arches and use cases.
> >
>
> Does it require any documentation in Documentation/ABI/..
Yes, it's necessary. Will do in next version.
I'm still discussing with Matt, exporting efi.flags seems not a good way
because they are more internal interfaces.
Probably I should export only a file 'old_map' instead.
>
> Vivek
>
> > Signed-off-by: Dave Young <dyo...@redhat.com>
> > ---
> > drivers/firmware/efi/efi.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > Index: linux-2.6/drivers/firmware/efi/efi.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/firmware/efi/efi.c
> > +++ linux-2.6/drivers/firmware/efi/efi.c
> > @@ -86,16 +86,19 @@ static ssize_t name##_show(struct kobjec
> > EFI_ATTR_SHOW(fw_vendor);
> > EFI_ATTR_SHOW(runtime);
> > EFI_ATTR_SHOW(config_table);
> > +EFI_ATTR_SHOW(flags);
> >
> > static struct kobj_attribute efi_attr_fw_vendor = __ATTR_RO(fw_vendor);
> > static struct kobj_attribute efi_attr_runtime = __ATTR_RO(runtime);
> > static struct kobj_attribute efi_attr_config_table =
> > __ATTR_RO(config_table);
> > +static struct kobj_attribute efi_attr_flags = __ATTR_RO(flags);
> >
> > static struct attribute *efi_subsys_attrs[] = {
> > &efi_attr_systab.attr,
> > &efi_attr_fw_vendor.attr,
> > &efi_attr_runtime.attr,
> > &efi_attr_config_table.attr,
> > + &efi_attr_flags.attr,
> > NULL,
> > };
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
