Am 27.05.2014 05:12, schrieb Alexander Shiyan:
Tue, 27 May 2014 00:12:34 +0200 от Alexander Holler <hol...@ahsoftware.de>:
Fix a common error in nand-drivers which do not set up a parent devicefor
the mtd-device by using a new inline function.
Signed-off-by: Alexander Holler <hol...@ahsoftware.de>
---
drivers/mtd/nand/pxa3xx_nand.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 7588fe2..7f62e7c 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -1584,8 +1584,7 @@ static int alloc_nand_resource(struct platform_device
*pdev)
host->mtd = mtd;
host->cs = cs;
host->info_data = info;
- mtd->priv = host;
- mtd->owner = THIS_MODULE;
+ mtd_setup_common_members(mtd, host, pdev);
chip->ecc.read_page = pxa3xx_nand_read_page_hwecc;
chip->ecc.write_page = pxa3xx_nand_write_page_hwecc;
--
Should we add "driver.owner = THIS_MODULE" field for struct platform_driver in
this case?
Yes. I assumed all drivers/modules already had an owner. I will check
them all and will send a v2 for those which don't have one. I wonder
what this field is used for if it works without. ;)
Regards,
Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
