(2014/05/20 11:11), Chen Yucong wrote: > mces_seen is a Per-CPU variable which should only be accessed by Per-CPU as > possible. So the > clear operation of mces_seen should also be lcoal to Per-CPU rather than > monarch CPU.
I don't think it should be local. Originally what we want to have here is memory to save mces_seen for each online cpus, such as a global array like mces_seen[cpus]. But at same time we don't want to preallocate big array enough for max possible cpus. So we use per-cpu store instead. > > Meanwhile, there is also a potential risk that mces_seen will not be be > cleared if a timeout > occors in mce_end for monarch CPU. As a reuslt, the stale value of mces_seen > will reappear > on the next mce. In case if we decide panic in mce path, uncleared mces_seen can be referred from memory dump. I suppose it will help trouble investigation. > > Based on the above reasons, this patch distirbute the clear operation of > mces_seen to Per-CPU > rather than only monarch CPU. "local" "occurs" "result" "distribute" I recommend you to use spell-checker for your postings... Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
