On Fri, May 16, 2014 at 05:56:41PM -0700, John Stultz wrote: > This version of the patch set corrects a few issues Miroslav pointed > out, as well as adapts his approach almost completely for the last > patch. This pulls the results in to be very close to his original > patch.
Ok, so it seems to be almost identical to my patch now. The only two differences seem to be the removal of the ntp_error correction to change the effective clock frequency at the current time instead of aligning it to the start of the tick and the flag to handle the xtime underflow. Can we get them in too? I think both are necessary to avoid having large steps in ntp_error which take long time to correct. You can see this in the nohz off freq100 result from the simulator, for example. > I'm not 100% sure we need the last patch in this series, as > it has additional computational cost and testing on real > hardware has shown NOHZ=y performance matching NOHZ=n with a > earlier version of just the first patch: > https://lkml.org/lkml/2014/1/13/501 > (though admittedly, the patch has changed since Richard's testing, > so the results are a bit stale). If I could get a sufficiently low update rate on real HW or a more accurate reference clock, I think I would be able to show you a difference. But even if we can't at this time, the removal of the complex feedback loop, which as you saw is difficult to keep working well in all cases (and we have tested only a very small number of them), is probably worth the extra computational cost. Thanks, > Below are some of the simulator results comparing this patchset > to vanilla and Miroslav's original patch. > Miroslav's original patch: > -------------------------- > > $ ./test1.sh > freq10 freq100 dev max > nohz on 0.00601 0.00028 74.0 279.4 > nohz off 0.05867 0.00204 0.2 0.6 > This patchset: > -------------- > > $ ./test1.sh > freq10 freq100 dev max > nohz on 0.00582 0.00033 74.1 279.9 > nohz off 0.06275 0.06440 0.4 1.4 -- Miroslav Lichvar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
