On Fri, 2014-05-16 at 12:02 +0000, Dmitry Kravkov wrote:
> > -----Original Message-----
> > From: netdev-ow...@vger.kernel.org [mailto:netdev-
> > ow...@vger.kernel.org] On Behalf Of Joe Perches
> > Sent: Friday, May 16, 2014 9:52 AM
> > To: Ariel Elior; Dmitry Kravkov
> > Cc: netdev; linux-kernel
> > Subject: [PATCH] bnx2x: Convert return 0 to return rc
> >
> > These "return 0;" uses seem wrong as there are
> > rc variables where error return values are set
> > but unused.
[]
> Thanks Joe for catching this!
>
> Acked-by: Dmitry Kravkov <dmitry.krav...@qlogic.com>
Hello Dmitry.
Couple things actually:
o Could you please update the MAINTAINER entry for
BNX2X? Ariel Elior's email address is still listed
as @broadcom and that seems to bounce.
o I found this via coccinelle actually.
Julia Lawall submitted a patch to remove unused
netdev_priv calls. I modified that to check for
any expression that returns an unused value and
found this and many others. There are a lot of
false positives though.
@@
local idexpression x;
expression E;
@@
-x = E;
... when != x
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
