On Thu, 24 Apr 2014, Vince Weaver wrote: > On Wed, 23 Apr 2014, Peter Zijlstra wrote: > > > > Something like so should do I suppose. > > > > --- > > Subject: perf: Fix perf_event_open(.flags) test > > > > Vince noticed that we test the (unsigned long) flags field against an > > (unsigned int) constant. This would allow setting the high bits on 64bit > > platforms and not get an error. > > > > There is nothing that uses the high bits, so it should be entirely > > harmless, but we don't want userspace to accidentally set them anyway, > > so fix the constants. > > > > Reported-by: Vince Weaver <vincent.wea...@maine.edu> > > Signed-off-by: Peter Zijlstra <pet...@infradead.org> > > Tested-by: Vince Weaver <vincent.wea...@maine.edu> > > Your patch fixes the problem, or at least the test I wrote to check the > issue now fails properly.
Even though this isn't as pressing an issue as the other perf_event problems, I wanted to make sure this patch didn't get forgotten... Vince -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
