On Wed, May 07, 2014 at 02:29:37PM -0700, j...@joshtriplett.org wrote:
> On Mon, Apr 28, 2014 at 05:25:03PM -0700, Paul E. McKenney wrote:
> > From: "Paul E. McKenney" <paul...@linux.vnet.ibm.com>
> >
> > The torture tests need to set specific values for their respective
> > Kconfig options (e.g., CONFIG_LOCK_TORTURE_TEST), and must therefore
> > filter any conflicting definitions from the Kconfig fragment
> > file. Unfortunately, the code in kvm-build.sh was looking only for
> > CONFIG_RCU_TORTURE_TEST. This commit therefore handles the general case
> > of CONFIG_[A-Z]*TORTURE_TEST.
>
> This doesn't match your code below, which includes an _ after the * .
>
> Also, one nit below.
>
> > Signed-off-by: Paul E. McKenney <paul...@linux.vnet.ibm.com>
>
> With the commit message fixed:
> Reviewed-by: Josh Triplett <j...@joshtriplett.org>
>
> > ---
> > tools/testing/selftests/rcutorture/bin/kvm-build.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-build.sh
> > b/tools/testing/selftests/rcutorture/bin/kvm-build.sh
> > index e838c775f709..6d0b76d918f4 100755
> > --- a/tools/testing/selftests/rcutorture/bin/kvm-build.sh
> > +++ b/tools/testing/selftests/rcutorture/bin/kvm-build.sh
> > @@ -45,7 +45,7 @@ T=/tmp/test-linux.sh.$$
> > trap 'rm -rf $T' 0
> > mkdir $T
> >
> > -cat ${config_template} | grep -v CONFIG_RCU_TORTURE_TEST > $T/config
> > +cat ${config_template} | grep -v 'CONFIG_[A-Z]*_TORTURE_TEST' > $T/config
>
> UUOC (useless use of cat): you can redirect from ${config_template}
> rather than catting it.
Both good points! Back when I was first using UNIX, that extra "cat"
would have cost me something like three seconds. How quickly we forget! ;-)
Thanx, Paul
> > cat << ___EOF___ >> $T/config
> > CONFIG_INITRAMFS_SOURCE="$TORTURE_INITRD"
> > CONFIG_VIRTIO_PCI=y
> > --
> > 1.8.1.5
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
