On Mon, Apr 21, 2014 at 10:23:46PM -0400, Steven Rostedt wrote:
>
> The return value for pevent_filter_match() is suppose to return FILTER_NONE
> if the event doesn't have a filter, and FILTER_NOEXIST if there is no filter
> at all. But the change 41e12e580a7 "tools lib traceevent: Refactor
> pevent_filter_match() to get rid of die()" replaced the return value
> with PEVENT_ERRNO__* values and added "backward compatibility" macros
> that used the old names. Unfortunately, the NOEXIST and NONE macros were
> swapped, and this broke users that use the old return names.
>
> Signed-off-by: Steven Rostedt <rost...@goodmis.org>
Acked-by: Jiri Olsa <jo...@redhat.com>
thanks,
jirka
> ---
> tools/lib/traceevent/event-parse.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/traceevent/event-parse.h
> b/tools/lib/traceevent/event-parse.h
> index 9c38181..d6c610a 100644
> --- a/tools/lib/traceevent/event-parse.h
> +++ b/tools/lib/traceevent/event-parse.h
> @@ -886,8 +886,8 @@ struct event_filter {
> struct event_filter *pevent_filter_alloc(struct pevent *pevent);
>
> /* for backward compatibility */
> -#define FILTER_NONE PEVENT_ERRNO__FILTER_NOT_FOUND
> -#define FILTER_NOEXIST PEVENT_ERRNO__NO_FILTER
> +#define FILTER_NONE PEVENT_ERRNO__NO_FILTER
> +#define FILTER_NOEXIST PEVENT_ERRNO__FILTER_NOT_FOUND
> #define FILTER_MISS PEVENT_ERRNO__FILTER_MISS
> #define FILTER_MATCH PEVENT_ERRNO__FILTER_MATCH
>
> --
> 1.8.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
