Hi, On Fri, Mar 21, 2014 at 01:56:49AM +0530, Suresh Gupta wrote: > From: Suresh Gupta <b42...@freescale.com> > > DMA mapping functions are moved to common place in udc_core.c > which expect the DMA operation of gadget device > > Signed-off-by: Suresh Gupta <b42...@freescale.com> > --- > Changes from previous version: > * Added description > > drivers/usb/gadget/fsl_udc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > b/drivers/usb/gadget/fsl_udc_core.c > index d68aa77..35cb972 100644 > --- a/drivers/usb/gadget/fsl_udc_core.c > +++ b/drivers/usb/gadget/fsl_udc_core.c > @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device > *pdev) > /* Setup gadget.dev and register with kernel */ > dev_set_name(&udc_controller->gadget.dev, "gadget"); > udc_controller->gadget.dev.of_node = pdev->dev.of_node; > + set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);
I'm still not convinced this is the best thing to do in a driver. set_dma_ops() isn't even exposed on include/linux/ and no other driver tries to call it. This is really something that should be done at arch level. Perhaps send a note to lakml and see if anybody has a better idea ? cheers -- balbi
signature.asc
Description: Digital signature
