Commit-ID: 521c42990e9d561ed5ed9f501f07639d0512b3c9
Gitweb: http://git.kernel.org/tip/521c42990e9d561ed5ed9f501f07639d0512b3c9
Author: Viresh Kumar <viresh.ku...@linaro.org>
AuthorDate: Tue, 15 Apr 2014 10:54:37 +0530
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate: Tue, 15 Apr 2014 20:26:44 +0200
tick-common: Fix wrong check in tick_check_replacement()
tick_check_replacement() returns if a replacement of clock_event_device is
possible or not. It does this as the first check:
if (tick_check_percpu(curdev, newdev, smp_processor_id()))
return false;
Thats wrong. tick_check_percpu() returns true when the device is
useable. Check for false instead.
[ tglx: Massaged changelog ]
Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>
Cc: <sta...@vger.kernel.org> # v3.11+
Cc: linaro-ker...@lists.linaro.org
Cc: fweis...@gmail.com
Cc: arvind.chau...@arm.com
Cc: linaro-network...@linaro.org
Link:
http://lkml.kernel.org/r/486a02efe0246635aaba786e24b42d316438bf3b.1397537987.git.viresh.ku...@linaro.org
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
---
kernel/time/tick-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 0156612..0a0608e 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -276,7 +276,7 @@ static bool tick_check_preferred(struct clock_event_device
*curdev,
bool tick_check_replacement(struct clock_event_device *curdev,
struct clock_event_device *newdev)
{
- if (tick_check_percpu(curdev, newdev, smp_processor_id()))
+ if (!tick_check_percpu(curdev, newdev, smp_processor_id()))
return false;
return tick_check_preferred(curdev, newdev);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
