On Thu, 17 Feb 2005 09:29:53 -0800, Jesse Barnes <[EMAIL PROTECTED]> wrote: > On Thursday, February 17, 2005 8:33 am, Jon Smirl wrote: > > > No, pci_map_rom shouldn't test the signature IMHO. While PCI ROMs should > > > have the signature to be recognized as containing valid firmware images > > > on x86 BIOSes an OF, it's just a convention on these platforms, and I > > > would rather let people put whatever they want in those ROMs and still > > > let them map it... > > > > pci_map_rom will return a pointer to any ROM it finds. It the > > signature is invalid the size returned will be zero. Is this ok or do > > we want it to do something different? > > Shouldn't it return NULL if the signature is invalid? >
But then you couldn't get to your non-standard ROMs > Jesse > -- Jon Smirl [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
