Benjamin Herrenschmidt wrote:
Index: linux-work/include/asm-generic/4level-fixup.h =================================================================== --- linux-work.orig/include/asm-generic/4level-fixup.h 2005-01-24 17:09:49.000000000 +1100 +++ linux-work/include/asm-generic/4level-fixup.h 2005-02-17 18:10:38.000000000 +1100 @@ -24,7 +24,7 @@ #define pud_bad(pud) 0 #define pud_present(pud) 1 #define pud_ERROR(pud) do { } while (0) -#define pud_clear(pud) do { } while (0) +#define pud_clear(pud) pgd_clear((pgd_t *)(pud))
Just a small nit - no cast needed here.
Well, do you know ? pud is a pud_t* and the arch is free to implement
pgd_clear as an inline with strong typing no ?
Yeah but if you're using the 4level-fixup.h header, then you get #define pud_t pgd_t
Not that I really mind, but in this header we've just avoided doing casts for that reason.
Nick
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
