do_each_thread/while_each_thread iterators are deprecated by
for_each_thread/for_each_process_thread() APIs.

Lets convert the callers in procfs. The ultimate goal is to remove the
struct task_struct::thread_group field and the corresponding
do_each_thread/while_each_thread iterators that are RCU unsafe.

Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Ingo Molnar <mi...@kernel.org>
Cc: Oleg Nesterov <o...@redhat.com>
Signed-off-by: Frederic Weisbecker <fweis...@gmail.com>
---
 fs/proc/array.c | 7 ++++---
 fs/proc/base.c  | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 656e401..b7df5d5 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -439,12 +439,13 @@ static int do_task_stat(struct seq_file *m, struct 
pid_namespace *ns,
 
                /* add up live thread stats at the group level */
                if (whole) {
-                       struct task_struct *t = task;
-                       do {
+                       struct task_struct *t;
+
+                       for_each_thread(task, t) {
                                min_flt += t->min_flt;
                                maj_flt += t->maj_flt;
                                gtime += task_gtime(t);
-                       } while_each_thread(task, t);
+                       }
 
                        min_flt += sig->min_flt;
                        maj_flt += sig->maj_flt;
diff --git a/fs/proc/base.c b/fs/proc/base.c
index b976062..f595d8e 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2437,10 +2437,10 @@ static int do_io_accounting(struct task_struct *task, 
char *buffer, int whole)
        }
 
        if (whole && lock_task_sighand(task, &flags)) {
-               struct task_struct *t = task;
+               struct task_struct *t;
 
                task_io_accounting_add(&acct, &task->signal->ioac);
-               while_each_thread(task, t)
+               for_each_thread(task, t)
                        task_io_accounting_add(&acct, &t->ioac);
 
                unlock_task_sighand(task, &flags);
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to