On 04/08, Oleg Nesterov wrote: > > On 04/08, Masami Hiramatsu wrote: > > > > (2014/04/05 3:51), Oleg Nesterov wrote: > > > > > > TODO: An error from adjust_ret_addr() shouldn't be silently ignored, > > > we should teach arch_uprobe_post_xol() or handle_singlestep() paths > > > to restart the probed insn in this case. And probably "adjust" can > > > be simplified and turned into set_ret_addr(). It seems that we do > > > not really need copy_from_user(), we can always calculate the value > > > we need to write into *regs->sp. > > > > It seems that you fixed this in 8/9, we don't need the TODO list in > > the description. > > Well, OK, I'll update the changelog and remove the "error ... ignored" > part. Although to be honest, I do not understand why do you think it > is bad to document the other problems you found while you were writing > the patch.
I'll remove it altogether. But I'll update the changelog in "Introduce sizeof_long() ..." from the next series to explain why I think adjust_ret_addr() must die. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
