[PATCH 3/5] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock

[Sebastian Andrzej Siewior]

The generic irq chip uses irq_gc_lock() for locking so the
enable/startup and type callbacks should use the same lock. None of
those registers (polarity, mask, enable) are used by the gpio part.

Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de>
---
 drivers/gpio/gpio-dwapb.c | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 541b893..752ccb1 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -20,7 +20,6 @@
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/platform_device.h>
-#include <linux/spinlock.h>
 
 #define GPIO_SWPORTA_DR                0x00
 #define GPIO_SWPORTA_DDR       0x04
@@ -110,30 +109,26 @@ static void dwapb_irq_enable(struct irq_data *d)
 {
        struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
        struct dwapb_gpio *gpio = igc->private;
-       struct bgpio_chip *bgc = &gpio->ports[0].bgc;
-       unsigned long flags;
        u32 val;
 
-       spin_lock_irqsave(&bgc->lock, flags);
+       irq_gc_lock(igc);
        val = readl(gpio->regs + GPIO_INTEN);
        val |= BIT(d->hwirq);
        writel(val, gpio->regs + GPIO_INTEN);
-       spin_unlock_irqrestore(&bgc->lock, flags);
+       irq_gc_unlock(igc);
 }
 
 static void dwapb_irq_disable(struct irq_data *d)
 {
        struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
        struct dwapb_gpio *gpio = igc->private;
-       struct bgpio_chip *bgc = &gpio->ports[0].bgc;
-       unsigned long flags;
        u32 val;
 
-       spin_lock_irqsave(&bgc->lock, flags);
+       irq_gc_lock(igc);
        val = readl(gpio->regs + GPIO_INTEN);
        val &= ~BIT(d->hwirq);
        writel(val, gpio->regs + GPIO_INTEN);
-       spin_unlock_irqrestore(&bgc->lock, flags);
+       irq_gc_unlock(igc);
 }
 
 static int dwapb_irq_reqres(struct irq_data *d)
@@ -163,15 +158,14 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 
type)
 {
        struct irq_chip_generic *igc = irq_data_get_irq_chip_data(d);
        struct dwapb_gpio *gpio = igc->private;
-       struct bgpio_chip *bgc = &gpio->ports[0].bgc;
        int bit = d->hwirq;
-       unsigned long level, polarity, flags;
+       unsigned long level, polarity;
 
        if (type & ~(IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING |
                     IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW))
                return -EINVAL;
 
-       spin_lock_irqsave(&bgc->lock, flags);
+       irq_gc_lock(igc);
        level = readl(gpio->regs + GPIO_INTTYPE_LEVEL);
        polarity = readl(gpio->regs + GPIO_INT_POLARITY);
 
@@ -200,7 +194,7 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
 
        writel(level, gpio->regs + GPIO_INTTYPE_LEVEL);
        writel(polarity, gpio->regs + GPIO_INT_POLARITY);
-       spin_unlock_irqrestore(&bgc->lock, flags);
+       irq_gc_unlock(igc);
 
        return 0;
 }
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/