On 04/03/2014 03:49 PM, Paul Bolle wrote: > On Thu, 2014-04-03 at 15:30 -0500, Alex Elder wrote: >> Currently CONFIG_ARCH_BCM_MOBILE is used to select all Broadcom >> mobile SoCs. Instead, use that only as a config menu switch, and >> define specific symbols like CONFIG_ARCH_BCM_281XX to select a >> particular SoC family. If ARCH_BCM_MOBILE is selected, all of the >> SoCs will be selected by default, but this way each can be disabled >> individually as well. >> >> This allows more precision in controlling what gets built under >> mach-bcm. Another benefit to doing this is that it makes it obvious >> that the code that implements SMC calls to control L2 cache is only >> used for BCM281XX (for example). >> >> Also use Kbuild's $(<modulename>-y) variable mechanism to build a >> single object file containing everything used for the bcm281xx board >> in arch/arm/mach-bcm. >> >> Note: This patch is based on the current arm-soc/for-next branch: >> e98cd72 arm-soc: document samsung merges >> >> The patch is available here: >> http://git.linaro.org/landing-teams/working/broadcom/kernel.git >> Branch review/mach-bcm-cleanup > > It seems the last two paragraphs should actually be below the "---" > marker. There's no need to include them in the commit explanation, is > there?
You're right. Sorry about that. I got another comment too and will be doing a v2 shortly. -Alex > >> Signed-off-by: Alex Elder <el...@linaro.org> >> --- > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/