On 03/28, Andrew Morton wrote: > > Now for a six-year-late code review: > > - How the heck can target==current in task_current_syscall()? > > - Less talk, more action: > > From: Andrew Morton <[email protected]> > Subject: lib/syscall.c: unexport task_current_syscall() > > It is only used by procfs and procfs cannot be a module. > > Signed-off-by: Andrew Morton <[email protected]> > --- > > lib/syscall.c | 1 - > 1 file changed, 1 deletion(-) > > diff -puN lib/syscall.c~a lib/syscall.c > --- a/lib/syscall.c~a > +++ a/lib/syscall.c > @@ -72,4 +72,3 @@ int task_current_syscall(struct task_str > > return 0; > } > -EXPORT_SYMBOL_GPL(task_current_syscall);
Well, I guess it was added for external tracing modules like systemtap. And in this case target==current is very likely. And for utrace modules, but it is dead. I do not see any usage of task_current_syscall() in git://sourceware.org/git/systemtap.git, so this change should not upset systemtap at least. And if we unexport task_current_syscall(), perhaps we should actually lib/syscall.c. proc_pid_syscall() can use syscall_get_*() instead. Or at least we can simplify it, I don't think /proc/ actually needs wait_task_inactive(). Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
