>>> On 01.04.14 at 12:15, <daeseok.y...@gmail.com> wrote: > It need to free dev_entry when it failed to assign to a new > slot on the virtual PCI bus. > > smatch says: > drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn: > possible memory leak of 'dev_entry' > > Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
As before Reviewed-by: Jan Beulich <jbeul...@suse.com> > --- > v2: The kfree() invocation is moved outside the locked region. > > drivers/xen/xen-pciback/vpci.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c > index 3165ce3..51afff9 100644 > --- a/drivers/xen/xen-pciback/vpci.c > +++ b/drivers/xen/xen-pciback/vpci.c > @@ -137,6 +137,8 @@ unlock: > /* Publish this device. */ > if (!err) > err = publish_cb(pdev, 0, 0, PCI_DEVFN(slot, func), devid); > + else > + kfree(dev_entry); > > out: > return err; > -- > 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
