>>> On 31.03.14 at 12:08, <daeseok.y...@gmail.com> wrote: > It need to free dev_entry when it failed to assign to a new > slot on the virtual PCI bus. > > smatch says: > drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn: > possible memory leak of 'dev_entry' > > Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> albeit the solution is not ideal: > --- a/drivers/xen/xen-pciback/vpci.c > +++ b/drivers/xen/xen-pciback/vpci.c > @@ -130,6 +130,7 @@ static int __xen_pcibk_add_pci_dev(struct > xen_pcibk_device *pdev, > err = -ENOMEM; > xenbus_dev_fatal(pdev->xdev, err, > "No more space on root virtual PCI bus"); > + kfree(dev_entry); > > unlock: > mutex_unlock(&vpci_dev->lock); The kfree() invocation would better be placed outside the locked region (e.g. in an else to the "if (!err)" a little further down). Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
