On Tue, 2014-03-25 at 23:03 +0100, Mathieu Maret wrote:
> Remove duplicate code
[]
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/android/binder.c
[]
> @@ -2685,11 +2685,9 @@ static long binder_ioctl(struct file *filp, unsigned
> int cmd, unsigned long arg)
> break;
> case BINDER_VERSION: {
> struct binder_version __user *ver = ubuf;
> - if (size != sizeof(struct binder_version)) {
> - ret = -EINVAL;
> - goto err;
> - }
> - if (put_user(BINDER_CURRENT_PROTOCOL_VERSION,
> +
> + if (size != sizeof(struct binder_version) ||
> + put_user(BINDER_CURRENT_PROTOCOL_VERSION,
> &ver->protocol_version)) {
When you do this, please align continuations at the appropriate
open parenthesis using maximal initial tabs and minimal spaces
for alignment.
if (size != sizeof(struct binder_version) ||
put_user(BINDER_CURRENT_PROTOCOL_VERSION,
&ver->protocol_version)) {
2 tabs then 4 spaces then "put_user"
3 tabs then 5 spaces then "&ver->"
using scripts/checkpatch.pl --strict should alert you to this.
And, either don't submit this until after 3.15-rc1 is out
and Greg KH starts taking patches again, or expect to be
very patient about getting any update on this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
