[PATCH] net/bridge: Use RCU_INIT_POINTER(x, NULL) in br_vlan.c

[Monam Agarwal]

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure       
is carried out before storing a pointer to that structure. 
And in the case of the NULL pointer, there is no structure to initialize. 
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, 
NULL)

Signed-off-by: Monam Agarwal <monamagarwal...@gmail.com>
---
 net/bridge/br_vlan.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index 8249ca7..5d5b101 100644
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -99,9 +99,9 @@ static int __vlan_del(struct net_port_vlans *v, u16 vid)
        v->num_vlans--;
        if (bitmap_empty(v->vlan_bitmap, VLAN_N_VID)) {
                if (v->port_idx)
-                       rcu_assign_pointer(v->parent.port->vlan_info, NULL);
+                       RCU_INIT_POINTER(v->parent.port->vlan_info, NULL);
                else
-                       rcu_assign_pointer(v->parent.br->vlan_info, NULL);
+                       RCU_INIT_POINTER(v->parent.br->vlan_info, NULL);
                kfree_rcu(v, rcu);
        }
        return 0;
@@ -113,9 +113,9 @@ static void __vlan_flush(struct net_port_vlans *v)
        v->pvid = 0;
        bitmap_zero(v->vlan_bitmap, VLAN_N_VID);
        if (v->port_idx)
-               rcu_assign_pointer(v->parent.port->vlan_info, NULL);
+               RCU_INIT_POINTER(v->parent.port->vlan_info, NULL);
        else
-               rcu_assign_pointer(v->parent.br->vlan_info, NULL);
+               RCU_INIT_POINTER(v->parent.br->vlan_info, NULL);
        kfree_rcu(v, rcu);
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/