* Dimitri Sivanich <sivan...@sgi.com> wrote:
> Fix conditional in gru_exit to match gru_init.
>
> Signed-off-by: Dimitri Sivanich <sivan...@sgi.com>
> ---
> drivers/misc/sgi-gru/grufile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/misc/sgi-gru/grufile.c
> ===================================================================
> --- linux.orig/drivers/misc/sgi-gru/grufile.c
> +++ linux/drivers/misc/sgi-gru/grufile.c
> @@ -573,7 +573,7 @@ exit0:
>
> static void __exit gru_exit(void)
> {
> - if (!is_uv_system())
> + if (!is_uv_system() || (is_uvx_hub() && !is_uv2_hub()))
> return;
Such an amalgation of three system specific conditionals is
disgusting, please at minimum factor out a helper routine so that such
mismatches cannot happen.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
