Holger Waechtler wrote: > Adrian Bunk wrote: > > >Before I'm getting flamed to death: > >This patch contains possible cleanups. If parts of this patch conflict > >with pending changes these parts of my patch have to be dropped. > > > >This patch contains the following possible cleanups: > >- make needlessly global code static > >- remove the following EXPORT_SYMBOL'ed but unused function: > > - bt8xx/bt878.c: bt878_find_by_i2c_adap > >- remove the following unused global functions: > > - dvb-core/dvb_demux.c: dmx_get_demuxes > > - dvb-core/dvb_demux.c: dvb_set_crc32 > >- remove the following unneeded EXPORT_SYMBOL's: > > - dvb-core/dvb_demux.c: dvb_dmx_swfilter_packet > > dvb_dmx_swfilter_packet() should remain exported to the public, > accessing this directly makes sense for some architectures.
Hm, I don't know any out-of-tree driver which is using it. Do you? Besides, it is roughly equivalent to dvb_dmx_swfilter_packets(demux, buf, 1) (the difference is in locking and the test for the MPEG-2 TS sync byte). IMHO the EXPORT_SYMBOL for dvb_dmx_swfilter_packet() can be removed. To me the patches look good and I'm going to apply them to linuxtv.org CVS. Thanks, Johannes PS: The linuxtv.org server will be down for maintenance over the weekend which includes the linux-dvb-maintainer list. No need to worry. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
